Fix suggestions with multiple corrections #129
Conversation
mfittko
force-pushed
the
fix-suggestions
branch
from
849d8bb
to
892a6f7
Compare
|
We're using this branch now as we think that the change is working well. Unfortunately this is not well covered by tests (yet) though, so if someone is able to help ot there, feel free to reach out. Anyone who's relying on this, feel free to use our fork's branch until this is merged. If you see any issues, please post them here. |
|
@haya14busa I think I fixed the issue and verified with a local devcontainer setup (see PR #130 ) |
|
can we trigger the workflows again? we're using this for 2 weeks now for most of our repos without a problem and we would like to see this in upstream |
| @@ -90,23 +90,44 @@ def build_range(offense) | |||
| # @param [RuboCop::Cop::Offense] offense | |||
| # @return [Array{Hash}] | |||
| def build_suggestions(offense) | |||
There was a problem hiding this comment.
This has two Rubocop metrics based warnings since it's a larger method now. Perhaps determining the positions/range and sorted corrections could each be extracted into a private method?
We don't see to have tests for this other than integration tests through Rubocop CLI. If its easier to write a unit test that would be fine but is there anyway we could update the test data with samples that would trigger the warnings before this change and then include it here to demonstrate that the fix is working as expected?
The suggestions feature is broken as it's ignoring any offenses with multiple corrections. This is leading to wrong or - at best - incomplete sugggestions.
Fixes #81 and #96
Examples (before fix):
Examples (with fix):
